Improve enforcement of linear commit history #1266
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the GitHub API to check commit parents in BASE and HEAD branches and ensure we are following a linear history. HEAD should not have any merge commits, so reject any HEAD branches where one or more commits have multiple parents. The tip of BASE should be a merge commit that includes the tip of HEAD, otherwise the workflow should reject. Change-type: minor Signed-off-by: Kyle Harding <[email protected]>
Signed-off-by: Kyle Harding <[email protected]>
|
Website deployed to CF Pages, 👀 preview link https://55e135e6.flowzone.pages.dev |
Page-
reviewed
Nov 19, 2024
Comment on lines
+1193
to
+1194
| - *getHeadBranchMergeCommits | ||
| - *rejectNonLinearHead |
There was a problem hiding this comment.
These seem like they must be run together and in order so I'm wondering why they aren't a single anchor since they are so 1-1 dependent?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the GitHub API to check commit parents in BASE and HEAD branches and ensure we are following a linear history.
HEAD should not have any merge commits, so reject any HEAD branches where one or more commits have multiple parents.
The tip of BASE should be a merge commit that includes the tip of HEAD, otherwise the workflow should reject.
Change-type: minor