-
-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: removed-link #1421
fix: removed-link #1421
Conversation
Hi @umangutkarsh, I'm afraid simply removing it will not work. The original sentence is
and if we remove it as per this PR it will become
which doesn't really make sense as a sentence. |
@limzykenneth i think ,it will be better to remove anchor tag from the link, but not removing the text remain it as plain text |
I agree, but then we'll need a link to redirect the user to the spreadsheet. Or should we change the sentence. What do you say? |
@harshsharma-11 Simply removing the link and not changing the text will also not make sense since it is referring to something that doesn't exist (ie. "There is a working spreadsheet here" but "here" points to nowhere). @umangutkarsh As mentioned in the original issue, the suggestion is to change/rephrase the section so that it does not refer to the spreadsheet. |
Hi @limzykenneth , I've rephrased the text in the |
Hi @limzykenneth, can you please review it? Thanks |
The two sentences are more or less saying the same thing so it feels like repeating now. Would you like some suggestions on possible rephrasing? |
Yeah sure. |
Hi @limzykenneth, I added -> This is for the english language. It cannot redirect to the existing resources, since there is no spreadsheet. Would be helpful if you suggest some phrases. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert changes to the translation files (es.yml, hi.yml, it.yml, ko.yml, and zh-Hans.yml) as they are just formatting changes but will have a unintended effects on the rendering of those pages.
@limzykenneth. I've made the changes, please review it. Thanks for your time. |
@limzykenneth do I have to make any other changes to the PR? If yes, please let me know. Thanks. |
Merged with d9c8283 |
Fixes #1375
Changes:
I replaced the broken link, by removing it.
Screenshots of the change: