-
-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #1375 Broken link in tutorial-guide.html #1388
base: main
Are you sure you want to change the base?
Fixes #1375 Broken link in tutorial-guide.html #1388
Conversation
.codesandbox/tasks.json
Outdated
{ | ||
// These tasks will run in order when initializing your CodeSandbox project. | ||
"setupTasks": [ | ||
{ | ||
"name": "Install Dependencies", | ||
"command": "npm install" | ||
} | ||
], | ||
|
||
// These tasks can be run from CodeSandbox. Running one will open a log in the app. | ||
"tasks": { | ||
"grunt": { | ||
"name": "grunt", | ||
"command": "npm run grunt", | ||
"runAtStart": false | ||
}, | ||
"assemble": { | ||
"name": "assemble", | ||
"command": "npm run assemble", | ||
"runAtStart": false | ||
}, | ||
"build": { | ||
"name": "build", | ||
"command": "npm run build", | ||
"runAtStart": false | ||
}, | ||
"test": { | ||
"name": "test", | ||
"command": "npm run test", | ||
"runAtStart": false | ||
}, | ||
"watch": { | ||
"name": "watch", | ||
"command": "npm run watch", | ||
"runAtStart": true | ||
}, | ||
"precommit": { | ||
"name": "precommit", | ||
"command": "npm run precommit", | ||
"runAtStart": false | ||
} | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this file as it is not related to the issue in question. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok I have removed it.
@@ -25,7 +25,7 @@ slug: learn/ | |||
<h2>{{#i18n "writing-a-tutorial-how-start-title"}}{{/i18n}}</h2> | |||
<ul class="list_view"> | |||
<li> | |||
{{#i18n "writing-a-tutorial-how-start-1"}}{{/i18n}}<a href="https://docs.google.com/spreadsheets/d/1sh3IwcCUY4Bm8N4fRZw6CwSDdQmmXgY_awjVj-UC8mo/edit#gid=0">{{#i18n "writing-a-tutorial-how-start-2"}}{{/i18n}}</a> | |||
{{#i18n "writing-a-tutorial-how-start-1"}}{{/i18n}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think changing it in this way works as it will just render as
Check that your proposed topic has not already been covered. There is that outlines in progress tutorials. If your topic is listed as in progress, perhaps you can add to work being done and contribute to preparing existing work for publication so please reach out to us.
which does not make sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to rephrase the paragraph in a different language but in the i18n-tracking.yml file, it shows me a lot of errors like duplicate p5.util so how to deal with it could you please help me in resolving the error? I'm new to open source please pardon me for my mistakes
My rephrase paragraph was look like -
Check that your proposed topic has not already been covered. You can search for existing tutorials on the topic by using a search engine or by browsing through online repositories. If your topic is listed as in progress, perhaps you can add to work being done and contribute to preparing existing work for publication so please reach out to us.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The p5.util stuff are fixed by #1397 so once that is merged can you try making the proposed changes again? Thanks.
Fixes #1375
Changes:
Simply removed the spreadsheet link with text