-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include Bulk Requests support + RPC trace related tables #3
Conversation
This PR also uses #2 as a base, and I'm unsure if we want to merge this and drop the prev one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good. Most of my comments are about logging :D
Hey @iand ! I just pushed a commit with the comments addressed - thank you so much for the feedback! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I will get this built and deployed so we can use it as a testbed. Thanks again for your contribution.
Description
With the coming merge/review of
lotus#10405
, the level of traces emitted and the way of pushing them will change. The PR includes trace batching through Elastic Search Bulk Requests and aggregating the Send/Recv RPC traces. Thus, this PR aims to upgrade thetrace-catcher
to support those changes.Tasks
_bulk
endpoint to the HTTP server to read batched traces-
rpc_event
(sent / recv)-
broadcast_message
(linked to the RPC event)-
ihave_message
(linked to the RPC event)-
ìwant_message
(linked to the RPC event)MessageID
encoding format to be persistable in the DBTesting
I'm currently testing this same branch on my testing server, and everything seems to be working fine with
lotus#10405