Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pixel Kernels (3/2): RGBD Kernels #152

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Conversation

horizon-blue
Copy link
Member

While working on the image kernels, I realized that it might be useful to have a unified class that sample the RGBD values jointly, so I'm introducing this utility class that takes in an color kernel (from #147) and a depth kernel (from #149) to create an RGBD kernel, which supports sample and logpdf computation.

This is a general class that's agnostic of the type of RGB and depth kernels -- it'll pass in the arguments it receives to both of the kernels during sample and logpdf call. Since both color and depth kernels have *args, **kwargs as part of their function signature, they should simply ignore additional arguments that's not relevant to them.

(I also just realized that I was referring to these classes as "kernels" but the actual class names are *Distributions... maybe I should fix these in a future PR.)

I'm submitting this PR to main for now. Once I'm wrapping up my local changes, I'm going to work on resolving merge conflicts with gen3d.

Test Plan

Similar to the previous PRs, I've added some unit tests to make sure that the kernels roughly have the behaviors that we expected:

pytest tests/gen3d/test_pixel_rgbd_kernels.py

@horizon-blue horizon-blue merged commit 01e917c into main Sep 10, 2024
7 checks passed
@horizon-blue horizon-blue deleted the xyw/gen3d/pixel-rgbd-kernel branch September 10, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant