Gamma functions #67
Merged
Gamma functions #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eightysteele
commented
Apr 8, 2024
| (+ (reduce (fn [sum [i l]] (+ sum (/ l (+ x i)))) 0.0 c) | ||
| 0.99999999999999709182))) | ||
|
|
||
| (defn inv-gamma-1pm1 |
There was a problem hiding this comment.
we could potentially ^:no-doc this
eightysteele
commented
Apr 8, 2024
| (* (/ t x) (dec c)) | ||
| (* x c)))))) | ||
|
|
||
| (defn log-gamma-1p |
There was a problem hiding this comment.
we could potentially ^:no-doc this
eightysteele
commented
Apr 8, 2024
| @@ -25,15 +27,15 @@ | |||
| (with-comparator (within 1e-11) | |||
There was a problem hiding this comment.
we could eventually pull this out into it's own gamma-test namespace.
sritchie
approved these changes
Apr 10, 2024
src/gen/distribution/math/gamma.cljc
Outdated
| [3 14.136097974741746] | ||
| [2 -59.59796035547549] | ||
| [1 57.15623566586292]]] | ||
| (+ (reduce (fn [sum [i l]] (+ sum (/ l (+ x i)))) 0.0 c) |
There was a problem hiding this comment.
slight style thing, you could start your reduction with this value instead of 0.0 and save a level of nesting
There was a problem hiding this comment.
yep, good catch—fixed.
src/gen/distribution/math/gamma.cljc
Outdated
| 0.166538611382291489501700795102105E+00 | ||
| -0.420026350340952355290039348754298E-01 | ||
| -0.655878071520253881077019515145390E+00]] | ||
| (if (< t 0) |
|
Fixed the nits, all checks passed—ready for merge. |
|
Boom, thanks for this, this is excellent work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR adds native gamma function support with implementation references and sources (see the
math.gammanamespace for details) and consolidates common math constants into a little namespace calledmath.utils.Testing
All existing tests pass (
bb test:clj,bb test:cljs).Next steps
I would love a spot check and any feedback, happy to make changes. Otherwise it is my belief that this is good to go.