Add cljc log-likelihood implementations #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #27 +/- ##
==========================================
- Coverage 56.08% 55.64% -0.45%
==========================================
Files 11 12 +1
Lines 460 523 +63
Branches 19 19
==========================================
+ Hits 258 291 +33
- Misses 183 213 +30
Partials 19 19
|
zane
approved these changes
Aug 24, 2023
zane
reviewed
Aug 24, 2023
There was a problem hiding this comment.
I suppose this should be .clj-kondo instead of .clj?
There was a problem hiding this comment.
I'm not going to change it here since this comes from upstream, and if I DO change it then the next time we run copy_configs it will copy in the clj version; but I will make a note to submit a PR upstream for this!
sritchie
force-pushed
the
sritchie/scores
branch
from
104b990
to
2531adf
Compare
sritchie
force-pushed
the
sritchie/scores
branch
from
2531adf
to
c557aca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are required for the
kixi.statscljc distributions, as well as for theSplittableRandomimplementation, and a similarMath.Randomversion for JavaScript.I'll add more unit tests locking in specific values, but I want to see about adding generative tests that lock in properties we care about.