assemble instance #241
Open
assemble instance #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stylemark webpack plugin will use the assemble-lite instance which tracks handlerbar files dependecy graph and cache the data to spped up build time BREAKING CHANGE: there should be no breaking changes, but the amount of functionality changing is high enough to have a major release note
|
if pull/240 is merged, it needs to be pulled into this branch and some small code updates also needs to be added. |
this was removed in the new implementation of pv-stylemark (v4.)
…ocess template output
… rendering the components use same behaviour in assemble instance as the normal assemble, which uses data files in layout directory only for components
mbehzad
force-pushed
the
feature/assemble-instance
branch
from
4312dc9 to
90a3a7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
== Description ==
This will re-enable the stylemark webpack plugin with an assemble instance (#91) which allows caching and creating dependency graph to only read, build, and write what is/will be changed.
This will increase the build time in watch mode from 20+ seconds to 1-2s
== Closes issue(s) ==
== Changes ==
== Affected Packages ==
assemble-lite
pv-stylemark