feat(pv-scripts): webpack config update #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use the current immplementation of sass to compile scss files BREAKING CHANGE: see https://sass-lang.com/documentation/breaking-changes for migration from node-sass to dart-sass
… feature/node-sass-to-dart-sass # Conflicts: # packages/pv-scripts/package-lock.json
… feature/node-sass-to-dart-sass # Conflicts: # packages/pv-scripts/package-lock.json
… replace with current versions
… feature/node-sass-to-dart-sass # Conflicts: # packages/pv-scripts/package-lock.json
… feature/webpack-update # Conflicts: # packages/pv-scripts/package-lock.json # packages/pv-scripts/package.json
webpack won't generate a dedicated "legacy" bundle which was meant to be used for internet explorer. only one (js) bundle and one set of configuration for that will be used BREAKING CHANGE: "legacy" output is removed. only the "modern" bundle is generated, without any "module" or "modern" prefix. this also applies to all configurations (e.g. no webpack.config.module.js or no `[modern]` group in browserlist)
… js file types (js,ts,jsx,tsx) also remove all babel plugins that are already part of env preset BREAKING CHANGE: (low-risk) webpack config is applied to jsx, ts and tsx files even when `useTS` or `useReact` are false in the pv.config.json. if you prefer to have a custom webpack config for these files instead, make sure to use `enforce: "pre"` in your custom webpack.config file
user can add e.g. `"babelDecorator": "2023-11"` to pv.config.js to use the new decorator proposal.
("legacy" will be the default version)
webpack rule to handle svg files with default and customizable comfiguration BREAKING CHANGE: (medium-risk) svg files will automatically be boundled. check https://github.com/pro-vision/fe-tools/tree/master/packages/pv-scripts#svg-loading to see if you need to change your configuration
mbehzad
changed the title
update webpack loader and plugin to their latest version BREAKING CHANGE: Minimum `Node.js` version supported by the webpack plugins is `18.12.0`
will detect what sass implementation user has installed (`sass-embedded`, `node-sass` or (dart-)`sass` which will outomatically be installed) and use that, this adds support for projects not wanting to migrate to the new sass
this allows for much faster `pv-scripts dev` start when the code hasn't been canged since the last time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
== Description ==
Couple of updates to the webpack config:
== Closes issue(s) ==
== Changes ==
== Affected Packages ==
pv-scripts