Remove deny(warnings) #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This setting prevents compiler from building the code with warnings. I think it is useful to be able to do that because often I prototype an implementation and want to see whether it compiles and it is ok if there are unadressed warnings such asunused imports. Also I want to be able to run tests and get feedback from them without addressing all the warnings. I think we have good protection at PR level as GH action would prevent pushing code that violates this no warnings rule.
|
I'll leave this to @martinthomson |
martinthomson
approved these changes
Nov 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This setting prevents compiler from building the code with warnings. I think it is useful to be able to do that because often I prototype an implementation and want to see whether it compiles and it is ok if there are unadressed warnings such asunused imports. Also I want to be able to run tests and get feedback from them without addressing all the warnings.
I think we have good protection at PR level as GH action would prevent pushing code that violates this no warnings rule.
I also enabled validation for
cargo docif we ever need to use it based on conversations in rust-lang/cargo#8424Verified it is working and failing build: https://github.com/akoshelev/raw-ipa/actions/runs/3486104797