Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce Serialized Size of HybridInfo #1485

Merged
merged 3 commits into from
Dec 8, 2024

Conversation

tyurek
Copy link
Collaborator

@tyurek tyurek commented Dec 8, 2024

This PR does a few things

  1. Changes the codebase to assume helper_origin is a static string and does not need to be stored anywhere. It is removed from structs and outputs and simply grabbed from the place where it's defined if needed.
  2. Additionally removes DOMAIN from serialized HybridInfo bytes.
  3. Adds a second "to_bytes" method for HybridInfo structs. While we don't need hybrid_info and DOMAIN to deserialize HybridInfo, they are needed when we're actually encrypting/decrypting. For those purposes, a new to_enc_bytes() function is added. (Let me know if anyone can come up with a better name for this).

@tyurek tyurek marked this pull request as ready for review December 8, 2024 00:50
Copy link

codecov bot commented Dec 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.28%. Comparing base (b27a4b3) to head (1d01a77).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1485      +/-   ##
==========================================
+ Coverage   93.26%   93.28%   +0.02%     
==========================================
  Files         239      239              
  Lines       43675    43532     -143     
==========================================
- Hits        40734    40610     -124     
+ Misses       2941     2922      -19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tyurek tyurek merged commit e7a234a into private-attribution:main Dec 8, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants