Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Solve issues related to WebRTC #1773

Merged
merged 7 commits into from
Mar 10, 2020
Merged

Solve issues related to WebRTC #1773

merged 7 commits into from
Mar 10, 2020

Conversation

Zenithium
Copy link
Contributor

@Zenithium Zenithium commented Mar 7, 2020 •
edited
Loading

Description

Closes: #1483
Closes: #298
Closes: #1522

@Zenithium Zenithium requested a review from a team March 7, 2020 23:59
@netlify
Copy link

netlify bot commented Mar 8, 2020 •
edited
Loading

Deploy preview for privacytools-io ready!

Built with commit 4d8004e

https://deploy-preview-1773--privacytools-io.netlify.com

@Zenithium
Copy link
Contributor Author

There seems to be conflicting information for the interface for doing this. @jonaharagon can you check that these steps are correct? Don't know anyone else who's an Apple user lol

@Zenithium Zenithium changed the title Add explanation for disabling WebRTC in Safari Solve issues related to WebRTC Mar 8, 2020
@Zenithium Zenithium requested a review from jonaharagon March 8, 2020 16:38
jonaharagon
jonaharagon reviewed Mar 9, 2020
View reviewed changes
Copy link
Contributor

@jonaharagon jonaharagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth mentioning that you don't need to disable WebRTC entirely in Safari to prevent IP leaks (and I am not sure if it is possible to disable WebRTC entirely??) -- Meaning that in the default config your IP is not leaked, but you are still able to make video calls (AFAIK? can double-check later) etc., which is definitely handy.

_includes/sections/browser-webrtc.html Outdated Show resolved Hide resolved
Zenithium and others added 2 commits March 9, 2020 19:50
@Zenithium @jonaharagon
Grammar is hard
4cd736a 
Co-Authored-By: Jonah Aragon <[email protected]>
@Zenithium
Corrected iOS to macOS
4d8004e 
iOS is for phones
Mikaela
Mikaela approved these changes Mar 10, 2020
View reviewed changes
Copy link
Contributor

@Mikaela Mikaela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after reading the resolved comments from Jonah

@Zenithium Zenithium requested a review from jonaharagon March 10, 2020 15:05
blacklight447
blacklight447 approved these changes Mar 10, 2020
View reviewed changes
Copy link
Collaborator

@blacklight447 blacklight447 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great so far, you have been doing lots of great things lately @Zenithium , keep it up :)!

@blacklight447 blacklight447 merged commit edd177f into privacytools:master Mar 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@blacklight447 blacklight447 blacklight447 approved these changes

@Mikaela Mikaela Mikaela approved these changes

@jonaharagon jonaharagon Awaiting requested review from jonaharagon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@Zenithium @Mikaela @jonaharagon @blacklight447