Migrate to click framework #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The click framework is a new framework for command line interfaces. We use a file for each command in the commands/ directory to keep things easier to manage. We add a new command section "certificate" - although it is a tokentype, but this makes creating certificates, CSRs... easier. Closes #45 Closes #44
|
Hello @cornelinux! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-04-23 15:02:25 UTC |
|
@laclaro Take a look at the tool in general, which will help you to see the use cases. |
according to the privacyIDEA repo.
|
To be honest, I did not read through all the lines. The tool seems to work as expected. Further testing will point us to possible issues with this migration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The click framework is a new framework for command line
interfaces. We use a file for each command in
the commands/ directory to keep things easier to manage.
We add a new command section "certificate" - although it
is a tokentype, but this makes creating certificates, CSRs...
easier.
Closes #45
Closes #44