fixed PushToken TTL_MINUTES validation

privacyidea · Dec 9, 2024 · 4a9621c · 4a9621c
1 parent 98ab966
commit 4a9621c
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 6 deletions.
diff --git a/lib/model/tokens/push_token.dart b/lib/model/tokens/push_token.dart
@@ -219,10 +219,7 @@ class PushToken extends Token {
         Token.ISSUER: const ObjectValidatorNullable<String>(defaultValue: ''),
         Token.SERIAL: const ObjectValidator<String>(),
         SSL_VERIFY: boolValidator.withDefault(true),
-        TTL_MINUTES: ObjectValidator<Duration>(
-          transformer: (v) => Duration(minutes: int.parse(v)),
-          defaultValue: const Duration(minutes: 10),
-        ),
+        TTL_MINUTES: intValidatorNullable,
         ENROLLMENT_CREDENTIAL: const ObjectValidatorNullable<String>(),
         ROLLOUT_URL: stringToUrivalidator,
         Token.IMAGE: stringToUriValidatorNullable,

diff --git a/test/unit_test/model/processor_result_test.dart b/test/unit_test/model/processor_result_test.dart
@@ -20,15 +20,41 @@ void _testProcessorResult() {
     });
     group('factories', () {
       test('success', () {
-        ProcessorResult<String> result = const ProcessorResult.success('data');
+        const ProcessorResult<String> result = ProcessorResult.success('data');
         expect(result, isA<ProcessorResultSuccess>());
         expect((result as ProcessorResultSuccess).resultData, 'data');
       });
       test('error', () {
-        const result = ProcessorResult.failed('error');
+        const ProcessorResult<String> result = ProcessorResult.failed('error');
         expect(result, isA<ProcessorResultFailed>());
         expect((result as ProcessorResultFailed).message, 'error');
       });
     });
+
+    group('is', () {
+      test('success', () {
+        const ProcessorResult<String> result = ProcessorResultSuccess('data');
+        expect(result.isSuccess, isTrue);
+        expect(result.isFailed, isFalse);
+      });
+      test('error', () {
+        const ProcessorResult<String> result = ProcessorResultFailed('error');
+        expect(result.isSuccess, isFalse);
+        expect(result.isFailed, isTrue);
+      });
+    });
+
+    group('as', () {
+      test('success', () {
+        const ProcessorResult<String> result = ProcessorResultSuccess('data');
+        expect(result.asSuccess, 'data');
+        expect(() => result.asFailed, throwsA(isA<AssertionError>()));
+      });
+      test('error', () {
+        const ProcessorResult<String> result = ProcessorResultFailed('error');
+        expect(result.asFailed, 'error');
+        expect(() => result.asSuccess, throwsA(isA<AssertionError>()));
+      });
+    });
   });
 }