185 cancel authentication when push is declined #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add default value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
PrivacyIDEAAuthenticatorand related resources to handle declined push notifications and improve error handling. The most important changes include adding a new constant, updating thePrivacyIDEAAuthenticatorclass to handle the new declined status, and modifying the JavaScript and template files to support these updates.Handling declined push notifications:
src/main/java/org/privacyidea/authenticator/Const.java: Added a new constantFORM_POLL_IN_BROWSER_DECLINEDto handle declined push notifications.src/main/java/org/privacyidea/authenticator/PrivacyIDEAAuthenticator.java: Updated theactionmethod to handle the newFORM_POLL_IN_BROWSER_DECLINEDattribute and added logic to manage declined push notifications. [1] [2] [3] [4]src/main/resources/theme-resources/resources/js/pi-eventListeners.js: Added a new case for the 'cancel' status to handle declined push notifications.src/main/resources/theme-resources/resources/js/pi-pollTransaction.worker.js: Updated the polling logic to handle the 'declined' status.src/main/resources/theme-resources/templates/privacyIDEA.ftl: Added a new hidden input field forpollInBrowserDeclinedto support the declined status in the form. [1] [2]These changes ensure that the system can properly manage and respond to declined push notifications, improving the overall robustness and user experience.