Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

41 add client parameter to requests #66

Merged
merged 35 commits into from
Nov 20, 2024

Conversation

lukasmatusiewicz
Copy link
Contributor

@lukasmatusiewicz lukasmatusiewicz commented Nov 19, 2024

This pull request includes several updates and improvements to the codebase, focusing on upgrading dependencies, refactoring code for consistency, and adding new features. The most important changes include upgrading the JaCoCo coverage report action, updating Java version and dependencies in the pom.xml, refactoring variable names for consistency, and adding proxy support in the Endpoint class.

Dependency and Configuration Updates:

  • Upgraded the JaCoCo coverage report action from v2 to v3 in the .github/workflows/build.yml file.
  • Updated the Java version from 1.8 to 11 and upgraded the okhttp dependency from version 4.10.0 to 4.12.0 in the pom.xml file. [1] [2]

Code Refactoring:

  • Refactored variable names for consistency in the Challenge class, changing transactionId to transactionID. [1] [2]
  • Renamed method pilog to piLog in the IPISimpleLogger interface.
  • Refactored variable names in the JSONParser class for improved readability and consistency. [1] [2] [3] [4] [5] [6]

Feature Additions:

  • Added support for proxy configuration in the Endpoint class, allowing the use of HTTP proxies for requests.

Tests:

  • Update tests

Import and Formatting Adjustments:

  • Reorganized imports in multiple files to follow a consistent import order and removed unused imports. [1] [2] [3]

@lukasmatusiewicz lukasmatusiewicz linked an issue Nov 19, 2024 that may be closed by this pull request
@lukasmatusiewicz lukasmatusiewicz linked an issue Nov 19, 2024 that may be closed by this pull request
test the new function
@lukasmatusiewicz lukasmatusiewicz linked an issue Nov 19, 2024 that may be closed by this pull request
@lukasmatusiewicz lukasmatusiewicz removed the request for review from nilsbehlen November 20, 2024 09:16
src/main/java/org/privacyidea/Endpoint.java Outdated Show resolved Hide resolved
src/main/java/org/privacyidea/PIResponse.java Outdated Show resolved Hide resolved
*/
public String otpMessage()
{
// Any challenge that is not WebAuthn, U2F or Push is considered OTP
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of removing the comment, the function should be adjusted to do what the comment says

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is just an info that sms, hotp, totp is simple considered as an OTP. The function is doing all good

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but it does not filter webauthn or u2f, just push

@nilsbehlen nilsbehlen merged commit af60956 into master Nov 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Security: Make all fields private rm U2F Add "client" parameter to requests
2 participants