-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
41 add client parameter to requests #66
Conversation
add get client ip
add get client ip
add client, rm u2f
add forward client ip
test the new function
*/ | ||
public String otpMessage() | ||
{ | ||
// Any challenge that is not WebAuthn, U2F or Push is considered OTP |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of removing the comment, the function should be adjusted to do what the comment says
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is just an info that sms, hotp, totp is simple considered as an OTP. The function is doing all good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but it does not filter webauthn or u2f, just push
This pull request includes several updates and improvements to the codebase, focusing on upgrading dependencies, refactoring code for consistency, and adding new features. The most important changes include upgrading the JaCoCo coverage report action, updating Java version and dependencies in the
pom.xml
, refactoring variable names for consistency, and adding proxy support in theEndpoint
class.Dependency and Configuration Updates:
v2
tov3
in the.github/workflows/build.yml
file.okhttp
dependency from version4.10.0
to4.12.0
in thepom.xml
file. [1] [2]Code Refactoring:
Challenge
class, changingtransactionId
totransactionID
. [1] [2]pilog
topiLog
in theIPISimpleLogger
interface.JSONParser
class for improved readability and consistency. [1] [2] [3] [4] [5] [6]Feature Additions:
Endpoint
class, allowing the use of HTTP proxies for requests.Tests:
Import and Formatting Adjustments: