Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add bandada information #213

Merged
merged 4 commits into from
Oct 30, 2024

Conversation

vplasencia
Copy link
Member

@vplasencia vplasencia commented Oct 28, 2024

Description

This PR:

  • Adds the Bandada project information.

  • Fixes a console warning.

  • Fixes styling with prettier.

Copy link

vercel bot commented Oct 28, 2024

@vplasencia is attempting to deploy a commit to the Privacy and Scaling Explorations Team on Vercel.

A member of the Team first needs to authorize it.

@vplasencia vplasencia marked this pull request as draft October 28, 2024 18:17
@vplasencia vplasencia marked this pull request as ready for review October 28, 2024 19:02
@vplasencia
Copy link
Member Author

vplasencia commented Oct 28, 2024

Hey @kalidiagne! I think that the repo should have the pnpm-lock.yaml file included. I tried to include it but I got this error: firebase/firebase-js-sdk#8494

I think it would be better to fix the pnpm version to use.

Copy link

vercel bot commented Oct 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
website-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2024 7:33pm
website-v2-production ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2024 7:33pm

@vplasencia vplasencia requested a review from kalidiagne October 28, 2024 20:46
@samajammin
Copy link
Member

Hey @kalidiagne! I think that the repo should have the pnpm-lock.yaml file included. I tried to include it but I got this error: firebase/firebase-js-sdk#8494

I think it would be better to fix the pnpm version to use.

Looks like @kalidiagne is trying to address this here? #214

@vplasencia
Copy link
Member Author

Hey @samajammin yes, correct!

@kalidiagne kalidiagne merged commit 8c445c1 into privacy-scaling-explorations:main Oct 30, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants