Improve performance #262
Merged
Improve performance #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use __dir__, as we do not need a sorted list - filter out private and internal items early, by checking on _ as a first character - remove the need for an expensive try/except handling Signed-off-by: Konrad Weihmann <[email protected]>
as this speeds up processing in a reasonable amount, without having a functional impact on users that already adjusted. Most of the deprecations where from 3.x times, so it's fine to remove them now Signed-off-by: Konrad Weihmann <[email protected]>
as in is much faster than any other find function Signed-off-by: Konrad Weihmann <[email protected]>
Signed-off-by: Konrad Weihmann <[email protected]>
priv-kweihmann
force-pushed
the
feat/speedups
branch
from
2c66bde to
87168ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.