-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: write components using @prismicio/editor-ui #968
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
DT-1098 AADev, I can write UI components in SM using the Editor's stack
We want to improve perceived quality, reduce the amount of duplicated styles/tokens and slowly move away from Theme UI (which is based on Emotion). The Editor project is using vanilla-extract and Radix UI with great success (and the Choosing a UI library for the Editor Notion page explains the rationale behind these choices). We are going to leverage the same technical stack to encourage cross-team collaboration and ease code reusability. From now on, prior to developing UI components, engineers will have to:
Additionally, all UI components will be implemented using Storybook. This will promote good separation of concerns (as we don't want domain code in UI components). Checklist
In the unlikely case vanilla-extract can't be used with Next.js version 13 (or later), we'll have to migrate to Vite (and create another Linear issue). An interesting GitHub issue to read about this potential incompatibility is vanilla-extract-css/vanilla-extract#929. |
What do you think about adding a build storybook GitHub action? It could be sure in the future to deploy the storybook, but currently it could help us to know when someone will break storybook because of the difficult deps management. |
LGTM otherwise, good to merge, super nice to have this now, thanks! |
Completes DT-1098: AADev, I can write UI components in SM using the Editor's stack.