Add variants to link to media #1522
Merged
+13
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dani-mp
commented
Dec 23, 2024
| @@ -41,7 +41,6 @@ export const LinkToMediaWidget: Widget<Link, typeof schema> = { | |||
| placeholder: "", | |||
| select: "media", | |||
| allowText: true, | |||
| repeat: false, | |||
There was a problem hiding this comment.
not sure why this was here but IMO it's not needed and it's misleading because there's no repeat in link to media
There was a problem hiding this comment.
I think it was because of the first version of types internal, when it was required to set repeat
xrutayisire
approved these changes
Dec 23, 2024
| @@ -41,7 +41,6 @@ export const LinkToMediaWidget: Widget<Link, typeof schema> = { | |||
| placeholder: "", | |||
| select: "media", | |||
| allowText: true, | |||
| repeat: false, | |||
There was a problem hiding this comment.
I think it was because of the first version of types internal, when it was required to set repeat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves:
https://linear.app/prismic/issue/DT-2527/aadev-i-can-enable-link-variants-for-link-to-media-field
Description
Checklist
Preview
How to QA 1
Footnotes
Please use these labels when submitting a review:
⚠️ #issue: Strongly suggest a change.
❓ #ask: Ask a question.
💡 #idea: Suggest an idea.
🎉 #nice: Share a compliment. ↩