Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate link variant mocks #1519

Merged
merged 3 commits into from
Dec 20, 2024
Merged

Generate link variant mocks #1519

merged 3 commits into from
Dec 20, 2024
+17 −18

Conversation

dani-mp
Copy link
Contributor

@dani-mp dani-mp commented Dec 20, 2024

Resolves:
Part of https://linear.app/prismic/issue/DT-2467/aauser-i-can-use-the-slice-simulator-with-the-new-link-variant.

Description

Uses the latest version of prismic mocks providing proper link variant mocks for the simulator.

Checklist

  • A comprehensive Linear ticket, providing sufficient context and details to facilitate the review of the PR, is linked to the PR.
  • If my changes require tests, I added them.
  • If my changes affect backward compatibility, it has been discussed.
  • If my changes require an update to the CONTRIBUTING.md guide, I updated it.

Preview

How to QA 1

Footnotes

  1. Please use these labels when submitting a review:
    ❓ #ask: Ask a question.
    💡 #idea: Suggest an idea.
    ⚠️ #issue: Strongly suggest a change.
    🎉 #nice: Share a compliment. ↩

@dani-mp dani-mp requested a review from a team as a code owner December 20, 2024 10:23
@linear Linear
Copy link

linear bot commented Dec 20, 2024

DT-2467 AAUser I can use the slice simulator with the new link variant, including mock data (prismic mocks)

@vercel Vercel
Copy link

vercel bot commented Dec 20, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
slice-machine ✅ Ready (Inspect) Visit Preview Dec 20, 2024 10:28am

@dani-mp dani-mp merged commit 98d8bd0 into dani/link-variant Dec 20, 2024
33 checks passed
@dani-mp dani-mp deleted the dani/link-variant-12 branch December 20, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BohdanOne BohdanOne BohdanOne approved these changes

@jomifepe jomifepe jomifepe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dani-mp @jomifepe @BohdanOne