feat(onboarding): enable another iteration of onboarding guide experiment #1514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
xrutayisire
approved these changes
Dec 18, 2024
| import { useUpdateAvailable } from "@/hooks/useUpdateAvailable"; | ||
|
|
||
| import { SharedOnboardingGuide } from "./SharedOnboardingGuide"; | ||
| import { SliceMachineOnboardingGuide } from "./SliceMachineOnboardingGuide/SliceMachineOnboardingGuide"; | ||
| import { useSharedOnboardingExperiment } from "./useSharedOnboardingExperiment"; | ||
|
|
||
| export function OnboardingGuide() { | ||
| const isVisible = useIsOnboardingGuideVisible(); | ||
| const isSharedExperimentEligible = useSharedOnboardingExperiment().eligible; | ||
|
|
||
| if (!isVisible) return null; |
There was a problem hiding this comment.
💡 You could put all null cases all together:
Suggested change
| if (!isVisible) return null; | |
| if (!isVisible || !isSharedExperimentEligible) return null; |
WDYT?
|
Btw I guess you confirm with Product the old onboarding guide should never come back. |
Yes, asked Come and he confirmed we don't want to keep any of the older versions of onboarding. |
BohdanOne
deleted the
BI/dt-2524-aapm-i-can-see-a-new-experiment-with-the-shared-onboarding
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: DT-2524
Description
In another iteration of onboarding guide experiment we display either shared onboarding guide or nothing.
I've updated key of the experiment to match new setup in Amplitude and removed code related to old guides that are no longer needed.
Checklist
Preview
How to QA 1
Footnotes
Please use these labels when submitting a review:
⚠️ #issue: Strongly suggest a change.
❓ #ask: Ask a question.
💡 #idea: Suggest an idea.
🎉 #nice: Share a compliment. ↩