Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link variant feedback link #1512

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Link variant feedback link #1512

merged 2 commits into from
Dec 18, 2024

Conversation

dani-mp
Copy link
Contributor

@dani-mp dani-mp commented Dec 17, 2024

Resolves:
https://linear.app/prismic/issue/DT-2510/aadev-i-can-provide-feedback-for-link-variant

Description

Adds the right link variant feedback link, provided by Mabel. It also changes a couple of copies after her feedback.

Checklist

  • A comprehensive Linear ticket, providing sufficient context and details to facilitate the review of the PR, is linked to the PR.
  • If my changes require tests, I added them.
  • If my changes affect backward compatibility, it has been discussed.
  • If my changes require an update to the CONTRIBUTING.md guide, I updated it.

Preview

How to QA 1

Footnotes

  1. Please use these labels when submitting a review:
    ❓ #ask: Ask a question.
    💡 #idea: Suggest an idea.
    ⚠️ #issue: Strongly suggest a change.
    🎉 #nice: Share a compliment.

@dani-mp dani-mp requested a review from a team as a code owner December 17, 2024 18:35
Copy link

vercel bot commented Dec 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
slice-machine ✅ Ready (Inspect) Visit Preview Dec 17, 2024 6:40pm

@dani-mp dani-mp changed the base branch from main to dani/link-variant December 17, 2024 18:36
@dani-mp dani-mp merged commit fe30507 into dani/link-variant Dec 18, 2024
32 of 33 checks passed
@dani-mp dani-mp deleted the dani/link-variant-7 branch December 18, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants