Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding link variants #1508

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Adding link variants #1508

merged 1 commit into from
Dec 16, 2024

Conversation

dani-mp
Copy link
Contributor

@dani-mp dani-mp commented Dec 16, 2024 •
edited
Loading

Resolves:
Part of https://linear.app/prismic/issue/DT-2474/aadev-i-can-create-a-link-field-with-the-new-option-to-enable-and.

New value added is empty. Pending product confirmation here.

Description

Allow adding up to 5 link variant options.

Checklist

  • A comprehensive Linear ticket, providing sufficient context and details to facilitate the review of the PR, is linked to the PR.
  • If my changes require tests, I added them.
  • If my changes affect backward compatibility, it has been discussed.
  • If my changes require an update to the CONTRIBUTING.md guide, I updated it.

Preview

image image

How to QA 1

Footnotes

  1. Please use these labels when submitting a review:
    ❓ #ask: Ask a question.
    💡 #idea: Suggest an idea.
    ⚠️ #issue: Strongly suggest a change.
    🎉 #nice: Share a compliment. ↩

@dani-mp dani-mp requested a review from a team as a code owner December 16, 2024 15:14
@linear Linear
Copy link

linear bot commented Dec 16, 2024

DT-2474 AADev, I can create a link field with the new option to enable and create variants

@vercel Vercel
Copy link

vercel bot commented Dec 16, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
slice-machine ✅ Ready (Inspect) Visit Preview Dec 16, 2024 3:20pm

@dani-mp dani-mp changed the base branch from main to dani/link-variant December 16, 2024 15:14
xrutayisire
xrutayisire approved these changes Dec 16, 2024
View reviewed changes
Copy link
Collaborator

@xrutayisire xrutayisire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dani-mp dani-mp merged commit f6d065c into dani/link-variant Dec 16, 2024
33 checks passed
@dani-mp dani-mp deleted the dani/link-variant-4 branch December 16, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xrutayisire xrutayisire xrutayisire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dani-mp @xrutayisire