Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: repeatable link badge #1494

Merged
merged 3 commits into from
Nov 29, 2024
Merged

Conversation

BohdanOne
Copy link
Contributor

Resolves: DT-2489

Description

Added a badge that gives a clear indication that field is repeatable (without need to open the edit modal).
repeatable-link-badge

Also fixed issue with buttons and icons in Field List Items shrinking or overflowing when Field label is very long which got even more noticeable with additional element of badge.
See screenshot before fix:
buttons-overflowing

Checklist

  • A comprehensive Linear ticket, providing sufficient context and details to facilitate the review of the PR, is linked to the PR.
  • If my changes require tests, I added them.
  • If my changes affect backward compatibility, it has been discussed.
  • If my changes require an update to the CONTRIBUTING.md guide, I updated it.

Preview

How to QA 1

Footnotes

  1. Please use these labels when submitting a review:
    ❓ #ask: Ask a question.
    💡 #idea: Suggest an idea.
    ⚠️ #issue: Strongly suggest a change.
    🎉 #nice: Share a compliment.

@BohdanOne BohdanOne requested a review from a team as a code owner November 29, 2024 14:17
Copy link

vercel bot commented Nov 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
slice-machine ✅ Ready (Inspect) Visit Preview Nov 29, 2024 2:24pm

@BohdanOne BohdanOne merged commit 39f7087 into repeatable-link Nov 29, 2024
33 checks passed
@BohdanOne BohdanOne deleted the BI/dt-2489-repeatable-badge branch November 29, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants