Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repetable link code snippets with key #1491

Merged
merged 3 commits into from
Nov 25, 2024
Merged

Repetable link code snippets with key #1491

merged 3 commits into from
Nov 25, 2024

Conversation

dani-mp
Copy link
Contributor

@dani-mp dani-mp commented Nov 25, 2024

Resolves:
https://linear.app/prismic/issue/DT-2452/better-repeatable-link-code-snippets

Description

Use the new link key to provide better repeatable link code snippets.

Checklist

  • A comprehensive Linear ticket, providing sufficient context and details to facilitate the review of the PR, is linked to the PR.
  • If my changes require tests, I added them.
  • If my changes affect backward compatibility, it has been discussed.
  • If my changes require an update to the CONTRIBUTING.md guide, I updated it.

Preview

How to QA 1

Footnotes

  1. Please use these labels when submitting a review:
    ❓ #ask: Ask a question.
    💡 #idea: Suggest an idea.
    ⚠️ #issue: Strongly suggest a change.
    🎉 #nice: Share a compliment. ↩

@dani-mp dani-mp requested a review from a team as a code owner November 25, 2024 15:15
@vercel Vercel
Copy link

vercel bot commented Nov 25, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
slice-machine ✅ Ready (Inspect) Visit Preview Nov 25, 2024 3:21pm

jomifepe
jomifepe approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@jomifepe jomifepe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@dani-mp dani-mp merged commit dd75569 into repeatable-link Nov 25, 2024
33 checks passed
@dani-mp dani-mp deleted the dani/repetable-link-code-snippets branch November 25, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jomifepe jomifepe jomifepe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dani-mp @jomifepe