Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix cookie vulnerability #1485

Merged
merged 1 commit into from
Nov 15, 2024
Merged

fix: fix cookie vulnerability #1485

merged 1 commit into from
Nov 15, 2024

Conversation

xrutayisire
Copy link
Collaborator

@xrutayisire xrutayisire commented Nov 15, 2024 •
edited
Loading

Resolves: DT-2442: Fix cookie vulnerability, #1482

Description

  • Update cookie version to fix the vulnerability

I tested the alpha version as a user, ran npm audit and found not vulnerability related to SM anymore

Checklist

  • A comprehensive Linear ticket, providing sufficient context and details to facilitate the review of the PR, is linked to the PR.
  • If my changes require tests, I added them.
  • If my changes affect backward compatibility, it has been discussed.
  • If my changes require an update to the CONTRIBUTING.md guide, I updated it.

Preview

How to QA 1

Footnotes

  1. Please use these labels when submitting a review:
    ❓ #ask: Ask a question.
    💡 #idea: Suggest an idea.
    ⚠️ #issue: Strongly suggest a change.
    🎉 #nice: Share a compliment. ↩

@xrutayisire xrutayisire requested a review from a team as a code owner November 15, 2024 11:21
@vercel Vercel
Copy link

vercel bot commented Nov 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
slice-machine ✅ Ready (Inspect) Visit Preview Nov 15, 2024 11:21am

jomifepe
jomifepe approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@jomifepe jomifepe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@xrutayisire xrutayisire merged commit d61ec2c into main Nov 15, 2024
34 checks passed
@xrutayisire xrutayisire deleted the xru/fix-vulns branch November 15, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jomifepe jomifepe jomifepe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xrutayisire @jomifepe