feat(slice-machine): add GitHub settings page #1285

bapmrl · 2024-02-05T15:27:42Z

Completes DT-1804, DT-1848 and DT-1950.

vercel · 2024-02-05T15:27:48Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
slice-machine	✅ Ready (Inspect)	Visit Preview	Feb 8, 2024 2:40pm

bapmrl

Hello @angeloashmore,

Here are some notes and questions I would like you to review ^^

Thank you,

packages/manager/src/constants/API_ENDPOINTS.ts

packages/manager/src/managers/git/GitManager.ts

packages/slice-machine/components/Forms/RenameVariationModal/RenameVariationModal.tsx

packages/slice-machine/src/features/settings/git/ConnectGitRepository.tsx

packages/slice-machine/src/features/settings/git/GitProvider.ts

packages/slice-machine/src/features/settings/git/GitRepositoriesSearch.tsx

packages/slice-machine/src/features/settings/git/GitRepositoryDisconnectDialog.tsx

packages/slice-machine/src/features/settings/git/GitRepositoryConnectDialog.tsx

packages/slice-machine/src/features/settings/git/GitRepositoryDisconnectDialog.tsx

angeloashmore

The UI works great! It looks and feels how it should. 🙂 There are some small changes requested below.

packages/slice-machine/src/features/settings/git/ConnectGitRepository.tsx

packages/slice-machine/src/features/settings/git/GitProvider.ts

packages/slice-machine/src/features/settings/git/GitProviderConnectButtons.tsx

packages/slice-machine/src/features/settings/git/GitRepositoryConnectDialog.tsx

angeloashmore · 2024-02-06T01:17:34Z

packages/slice-machine/src/features/settings/git/GitRepositoryConnectDialog.tsx

+  const providerConfig = gitProviderToConfig[repo.provider];
+  const { updateToken } = useWriteAPIToken({ git: repo });
+  return (
+    <Dialog size={{ width: 448, height: "auto" }} trigger={trigger}>


The Dialog is closable while the token is being saved. Is it possible to disable closing it while it is loading? Or maybe we can disable the "X" and clicking outside the dialog completely, and only allow closing via the "Cancel" button?

I think it's possible, but not now as we would need to update the Editor's Dialog component to:

Disable the ESC keyboard shortcut.

Disable dismissal by clicking the overlay.

Potentially disable the "Cancel" button.

Before doing any of that, I think it would be safer to have @benjammartin's thoughts (knowing we need to have accessibility in mind).

Is there a way to continue processing in the background after closing the modal? We'll need a toaster for confirmation or error messages in this scenario.

Do we need to check the viability of the token?

Is there a way to continue processing in the background after closing the modal? We'll need a toaster for confirmation or error messages in this scenario.

I think we can either:

Completely disable closing the dialog.
→ It could be frustrating for users.

Allow closing the dialog, but disable the Connect/Disconnect buttons while the request is running. Once it succeeds, display a success toast.
→ It would probably better as users would be able to leave the Settings page.

What do you think? Do you see a better way of handling it?

Do we need to check the viability of the token?

What do you mean? Are you asking if there's a specific token format that we could validate in the dialog's form?

The second solution is good.

In both solutions one and two, my only concern is the token's validity. Do we implement a way to check the token’s validity?

Since it’s a temporary solution, I believe that’s not an issue anyway.

If the second solution requires more time, I’m ok with releasing the first one.

Let me know.

Hello @angeloashmore,

Does the backend reject invalid Write API tokens? Do you think there's a format we could validate on the frontend?

Thank you,

packages/slice-machine/src/features/settings/git/GitRepositoryDisconnectDialog.tsx

packages/slice-machine/src/features/settings/git/GitRepositoriesList.tsx

packages/slice-machine/src/features/settings/git/ConnectGitRepository.tsx

packages/slice-machine/src/features/settings/git/GitRepositoryConnectDialog.tsx

linear · 2024-02-08T08:17:17Z

DT-1848 AAUser, I can use a Settings page to connect and disconnect a GitHub app to a Prismic repository

DT-1804 AAUser, I expect the confirmation button for deleting a variation to be red

linear · 2024-02-08T14:18:30Z

DT-1950 AAUser, I can access the Settings page only if my repository is part of the collaboration beta

bapmrl self-assigned this Feb 5, 2024

This was referenced Feb 5, 2024

feat(slice-machine): add GitHub settings page #1275

Closed

feat(slice-machine-ui): Git integration demo #1274

Closed

vercel bot deployed to Preview February 5, 2024 15:34 View deployment

bapmrl force-pushed the bmo/add-github-settings-page branch 2 times, most recently from 1eaede2 to 0ef02f8 Compare February 5, 2024 15:46

vercel bot deployed to Preview February 5, 2024 15:54 View deployment

bapmrl commented Feb 5, 2024

View reviewed changes

packages/slice-machine/src/features/settings/git/GitRepositoryDisconnectDialog.tsx Show resolved Hide resolved

angeloashmore requested changes Feb 6, 2024

View reviewed changes

packages/slice-machine/src/features/settings/git/GitRepositoryConnectDialog.tsx Show resolved Hide resolved

bapmrl force-pushed the bmo/add-github-settings-page branch from 0ef02f8 to 80089c8 Compare February 6, 2024 08:23

vercel bot deployed to Preview February 6, 2024 08:29 View deployment

bapmrl force-pushed the bmo/add-github-settings-page branch from 80089c8 to d9088e8 Compare February 6, 2024 08:38

vercel bot deployed to Preview February 6, 2024 08:44 View deployment

bapmrl force-pushed the bmo/add-github-settings-page branch from d9088e8 to cd7c68e Compare February 6, 2024 08:48

vercel bot deployed to Preview February 6, 2024 08:53 View deployment

bapmrl force-pushed the bmo/add-github-settings-page branch from cd7c68e to 4bcea38 Compare February 6, 2024 16:12

vercel bot deployed to Preview February 6, 2024 16:18 View deployment

vercel bot deployed to Preview February 8, 2024 00:32 View deployment

bapmrl force-pushed the bmo/add-github-settings-page branch from c743f29 to fd8de81 Compare February 8, 2024 10:47

vercel bot deployed to Preview February 8, 2024 10:52 View deployment

bapmrl and others added 4 commits February 8, 2024 14:19

feat(slice-machine): add GitHub settings page

79ec11e

fix: remove unintended $ in Write API token message

58dc18f

feat: use production GitHub app

435185b

fix: put useUser back

aa83662

bapmrl force-pushed the bmo/add-github-settings-page branch from fd8de81 to aa83662 Compare February 8, 2024 13:39

fix: add missing Express route

8530096

vercel bot deployed to Preview February 8, 2024 13:55 View deployment

vercel bot deployed to Preview February 8, 2024 14:22 View deployment

bapmrl force-pushed the bmo/add-github-settings-page branch from e5b6b07 to d4e705f Compare February 8, 2024 14:26

vercel bot deployed to Preview February 8, 2024 14:32 View deployment

feat: add useGitIntegrationExperiment

e15005f

bapmrl force-pushed the bmo/add-github-settings-page branch from d4e705f to e15005f Compare February 8, 2024 14:35

vercel bot deployed to Preview February 8, 2024 14:40 View deployment

bapmrl merged commit 71c73a5 into main Feb 8, 2024
34 checks passed

bapmrl deleted the bmo/add-github-settings-page branch February 8, 2024 15:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(slice-machine): add GitHub settings page #1285

feat(slice-machine): add GitHub settings page #1285

bapmrl commented Feb 5, 2024 •

edited

Loading

vercel bot commented Feb 5, 2024 •

edited

Loading

bapmrl left a comment

angeloashmore left a comment

angeloashmore Feb 6, 2024

bapmrl Feb 6, 2024 •

edited

Loading

benjammartin Feb 7, 2024

bapmrl Feb 8, 2024 •

edited

Loading

benjammartin Feb 8, 2024

benjammartin Feb 8, 2024 •

edited

Loading

benjammartin Feb 8, 2024

bapmrl Feb 8, 2024 •

edited

Loading

linear bot commented Feb 8, 2024

linear bot commented Feb 8, 2024

feat(slice-machine): add GitHub settings page #1285

feat(slice-machine): add GitHub settings page #1285

Conversation

bapmrl commented Feb 5, 2024 • edited Loading

vercel bot commented Feb 5, 2024 • edited Loading

bapmrl left a comment

Choose a reason for hiding this comment

angeloashmore left a comment

Choose a reason for hiding this comment

angeloashmore Feb 6, 2024

Choose a reason for hiding this comment

bapmrl Feb 6, 2024 • edited Loading

Choose a reason for hiding this comment

benjammartin Feb 7, 2024

Choose a reason for hiding this comment

bapmrl Feb 8, 2024 • edited Loading

Choose a reason for hiding this comment

benjammartin Feb 8, 2024

Choose a reason for hiding this comment

benjammartin Feb 8, 2024 • edited Loading

Choose a reason for hiding this comment

benjammartin Feb 8, 2024

Choose a reason for hiding this comment

bapmrl Feb 8, 2024 • edited Loading

Choose a reason for hiding this comment

linear bot commented Feb 8, 2024

linear bot commented Feb 8, 2024

bapmrl commented Feb 5, 2024 •

edited

Loading

vercel bot commented Feb 5, 2024 •

edited

Loading

bapmrl Feb 6, 2024 •

edited

Loading

bapmrl Feb 8, 2024 •

edited

Loading

benjammartin Feb 8, 2024 •

edited

Loading

bapmrl Feb 8, 2024 •

edited

Loading