-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(manager): add GitManager
#1268
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work! I really like the new createAPIFixture
function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm approving 😊 There's just a small conversation remaining. You can add a comment for the null
value if you also think it's useful.
Context
DT-1891
The Solution
Add
GitManager
(accessible viamanager.git
) with the following methods:createGitHubAuthState()
fetchOwners()
fetchRepos()
fetchLinkedRepos()
linkRepo()
unlinkRepo()
checkHasWriteAPIToken()
updateWriteAPIToken()
deleteWriteAPIToken()
The tests introduced in this PR cover ~80% of the code, which is sufficient for a first release.
Impact / Dependencies
This PR allows us to implement the Git integration UI.
This PR also introduces a drastically simpler method for writing manager tests (inspired by @xrutayisire's Playwright setup). Only the new
GitManager
tests use the new method, but we can migrate existing tests to the new method over time.Checklist before requesting a review