Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(init): Rework init end message #1186

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

xrutayisire
Copy link
Collaborator

Context

The Solution

  • One path for all, only propose to run Slice Machine at the end

Impact / Dependencies

  • Users will always start slice machine directly and stop going sometimes to the repository

Checklist before requesting a review

  • I hereby declare my code ready for review.
  • If it is a critical feature, I have added tests.
  • The CI is successful.
  • If there could backward compatibility issues, it has been discussed and planned.

Preview

Screenshot 2023-10-23 at 14 12 21

@linear
Copy link

linear bot commented Oct 23, 2023

DT-1698 [init] Too many exit links at the end

At the end of the init the goal is to only give the next step we want the user to do and not too many links. No other exit than run slice machine.

Screenshot 2023-10-19 at 18.42.28.png

COPY to find.

Proposal:

Slice Machine => Initialization successful!

Great, you're one step away to open Slice Machine. You can now run Slice Machine.

? Do you want to continue the setup by running Slice Machine (npm run slicemachnine)? > (Y/n)

@vercel
Copy link

vercel bot commented Oct 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
slice-machine ✅ Ready (Inspect) Visit Preview Oct 23, 2023 0:28am

Copy link
Member

@lihbr lihbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some small suggestions in case user don't want to start right away 🤔

packages/init/src/SliceMachineInitProcess.ts Show resolved Hide resolved
packages/init/src/SliceMachineInitProcess.ts Show resolved Hide resolved
@xrutayisire xrutayisire changed the title fix(init): Rework init end message [1.19.0] fix(init): Rework init end message Oct 23, 2023
@xrutayisire xrutayisire merged commit cc61ae6 into dev-next-release Oct 23, 2023
23 checks passed
@xrutayisire xrutayisire deleted the xru/clear-init-end-message branch October 23, 2023 15:33
@bapmrl bapmrl changed the title [1.19.0] fix(init): Rework init end message fix(init): Rework init end message Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants