Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(repository name): Repository name length can be up to 63 and not only 30 characters #1175

Merged
merged 1 commit into from
Oct 20, 2023
Merged

fix(repository name): Repository name length can be up to 63 and not only 30 characters #1175

merged 1 commit into from
Oct 20, 2023

Conversation

xrutayisire
Copy link
Collaborator

Context

The Solution

  • Created constant in order to save the correct min max repository name length

Impact / Dependencies

  • Prevent user to have an error after creating a valid repository name in wroom

Checklist before requesting a review

  • I hereby declare my code ready for review.
  • If it is a critical feature, I have added tests.
  • The CI is successful.
  • If there could backward compatibility issues, it has been discussed and planned.

@linear
Copy link

linear bot commented Oct 19, 2023

DT-1688 [init] Repository name must be 30 characters long or less

The goal of this issue is to let users do an init with a valid repository name that is more than 30 characters but accepted when you create it from the dashboard.

At the moment, we don't have the same validation as the backend and so user cannot do an init after creating a long repository name on the dashboard.

@vercel
Copy link

vercel bot commented Oct 19, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
slice-machine ✅ Ready (Inspect) Visit Preview Oct 20, 2023 2:43pm

@xrutayisire xrutayisire force-pushed the xru/repository-name-validation branch from 1814bc2 to af5963a Compare October 19, 2023 10:29
@xrutayisire xrutayisire changed the title ffix(repository name): Repository name length can be up to 63 and not only 30 characters fix(repository name): Repository name length can be up to 63 and not only 30 characters Oct 19, 2023
bapmrl
bapmrl requested changes Oct 19, 2023
View reviewed changes
packages/init/src/constants.ts Outdated Show resolved Hide resolved
packages/manager/src/constants/REPOSITORY.ts Outdated Show resolved Hide resolved
packages/manager/src/constants/REPOSITORY.ts Outdated Show resolved Hide resolved
packages/init/src/SliceMachineInitProcess.ts Outdated Show resolved Hide resolved
@xrutayisire xrutayisire force-pushed the xru/repository-name-validation branch from af5963a to a64c55f Compare October 19, 2023 17:05
@xrutayisire xrutayisire force-pushed the xru/repository-name-validation branch from a64c55f to 165420a Compare October 19, 2023 17:24
bapmrl
bapmrl approved these changes Oct 20, 2023
View reviewed changes
packages/init/src/lib/repositoryDomain.ts Outdated Show resolved Hide resolved
@xrutayisire xrutayisire force-pushed the xru/repository-name-validation branch from 165420a to 5ccd590 Compare October 20, 2023 14:37
@xrutayisire xrutayisire merged commit aa5ad18 into dev-next-release Oct 20, 2023
23 checks passed
@xrutayisire xrutayisire deleted the xru/repository-name-validation branch October 20, 2023 14:47
@bapmrl bapmrl mentioned this pull request Oct 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lihbr lihbr lihbr left review comments

@bapmrl bapmrl bapmrl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xrutayisire @bapmrl @lihbr