Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(init): Fix missing Sentry logs for init errors #1169

Merged
merged 1 commit into from
Oct 16, 2023
Merged

fix(init): Fix missing Sentry logs for init errors #1169

merged 1 commit into from
Oct 16, 2023

Conversation

xrutayisire
Copy link
Collaborator

Context

  • Part of DT-1685
    • It will not solve the issue, but ensure we have more details to solve it

The Solution

  • Add the whole error to Sentry when init fail because of deps installation
  • Ensure the value display in Sentry is long enough to understand the error

Impact / Dependencies

  • Sentry will have bigger payloads for the init project

Checklist before requesting a review

  • I hereby declare my code ready for review.
  • If it is a critical feature, I have added tests.
  • The CI is successful.
  • If there could backward compatibility issues, it has been discussed and planned.

@linear
Copy link

linear bot commented Oct 16, 2023

DT-1685 Init error "Command failed with exit code 1"

@vercel
Copy link

vercel bot commented Oct 16, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
slice-machine ✅ Ready (Inspect) Visit Preview Oct 16, 2023 10:19am

@bapmrl bapmrl changed the base branch from master to dev-next-release October 16, 2023 10:18
@xrutayisire xrutayisire merged commit e9a1881 into dev-next-release Oct 16, 2023
@xrutayisire xrutayisire deleted the xru/improve-sentry-init-errors branch October 16, 2023 10:21
@xrutayisire xrutayisire mentioned this pull request Oct 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bapmrl bapmrl bapmrl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xrutayisire @bapmrl