Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(slice-machine): convert legacy slice dialog overflow (DT-1677) #1168

Merged
merged 1 commit into from
Oct 12, 2023
Merged

fix(slice-machine): convert legacy slice dialog overflow (DT-1677) #1168

merged 1 commit into from
Oct 12, 2023

Conversation

lihbr
Copy link
Member

@lihbr lihbr commented Oct 12, 2023

Context

Overflow issue on the convert legacy slice dialog.

Checklist before requesting a review

  • I hereby declare my code ready for review.
  • If it is a critical feature, I have added tests.
  • The CI is successful.
  • If there could backward compatibility issues, it has been discussed and planned.

@vercel
Copy link

vercel bot commented Oct 12, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
slice-machine ✅ Ready (Inspect) Visit Preview Oct 12, 2023 9:12am

@linear
Copy link

linear bot commented Oct 12, 2023

DT-1677 Legacy Slice Upgrader Dialog Overflow

https://prismic-team.slack.com/archives/C02L3FN3AJK/p1697042795227759

image.png

@bapmrl bapmrl merged commit c00e774 into dev-next-release Oct 12, 2023
@bapmrl bapmrl deleted the lh/legacy-slice-dialog-overflow branch October 12, 2023 10:10
@bapmrl bapmrl mentioned this pull request Oct 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bapmrl bapmrl bapmrl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lihbr @bapmrl