Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(review): Satisfaction modal for advanced repository #1167

Merged

Conversation

xrutayisire
Copy link
Collaborator

Context

The Solution

  • Added a new manager call to get documents count
  • Added a new shared hook to fetch documents count
  • Update review modal to use documents count to display or not the review modal
  • Ensure the review modal has the correct display and tracking

Impact / Dependencies

  • Currently checking perf issue with the current work, if it's a problem or not

Checklist before requesting a review

  • I hereby declare my code ready for review.
  • If it is a critical feature, I have added tests.
  • The CI is successful.
  • If there could backward compatibility issues, it has been discussed and planned.

@linear
Copy link

linear bot commented Oct 12, 2023

DT-1656 AAUser, I can give my satisfaction after >20 documents published in my repo

Context:

  • We want to increase our number of big projects (>200 Docs)
  • In order to do that, we believe we should monitor and increase satisfaction of retained users

Acceptance:

  • Display the current satisfaction modal on these criteria
    • When the user is logged in
    • When the first satisfaction modal for onboarding has already been displayed
    • And the repository is part of contains more than 20 documents
    • Display it on any page of Slice Machine
  • Keep ALSO the current modal

Text:

  • Title : "Share feedback"
  • Question : "Overall, how satisfied or dissatisfied are you with your Slice Machine experience so far?"
  • Message : "Tell me more..."

Scale:

  • From 1 (Very dissatisfied)
  • To 5 (Very satisfied)

Tracking:

  • New "type" property in the "Slice Machine review" event
  • "type" value can be "onboarding" | "advanced repository"

@vercel
Copy link

vercel bot commented Oct 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
slice-machine ✅ Ready (Inspect) Visit Preview Oct 16, 2023 8:44am

@xrutayisire xrutayisire force-pushed the xru/satisfaction-modal-advanced-repository branch from 99454d4 to 4237a13 Compare October 12, 2023 14:25
Base automatically changed from dev-next-release to master October 12, 2023 15:21
@xrutayisire xrutayisire force-pushed the xru/satisfaction-modal-advanced-repository branch from 4237a13 to b53b2f6 Compare October 12, 2023 15:38
@xrutayisire xrutayisire force-pushed the xru/satisfaction-modal-advanced-repository branch from b53b2f6 to 0a46956 Compare October 12, 2023 17:29
Copy link
Collaborator

@bapmrl bapmrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice work! I just have some minor comments 😊

@xrutayisire xrutayisire force-pushed the xru/satisfaction-modal-advanced-repository branch from 6c0b82e to a34ac50 Compare October 16, 2023 08:39
@xrutayisire xrutayisire marked this pull request as ready for review October 16, 2023 10:02
@bapmrl bapmrl changed the base branch from master to dev-next-release October 16, 2023 10:08
@xrutayisire xrutayisire merged commit 46e0c16 into dev-next-release Oct 16, 2023
23 checks passed
@xrutayisire xrutayisire deleted the xru/satisfaction-modal-advanced-repository branch October 16, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants