feat: prevent updating slices and custom types with reserved name

prismicio · Dec 13, 2024 · f9f5cdb · f9f5cdb
1 parent fe248b6
commit f9f5cdb
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 13 deletions.
diff --git a/...slice-machine/src/legacy/components/Forms/RenameCustomTypeModal/RenameCustomTypeModal.tsx b/...slice-machine/src/legacy/components/Forms/RenameCustomTypeModal/RenameCustomTypeModal.tsx
@@ -103,6 +103,10 @@ export const RenameCustomTypeModal: React.FC<RenameCustomTypeModalProps> = ({
           })} name is already taken.`;
         }
 
+        if (["update", "insert"].includes(newName.toLowerCase())) {
+          errors.customTypeName = `Name "${newName}" is reserved for Slice Machine use.`;
+        }
+
         return Object.keys(errors).length > 0 ? errors : undefined;
       }}
     >

diff --git a/playwright/tests/customTypes/customTypesTable.spec.ts b/playwright/tests/customTypes/customTypesTable.spec.ts
@@ -70,15 +70,11 @@ test("I cannot create a custom type with a name update or insert", async ({
   await customTypesTablePage.openCreateDialog();
 
   await expect(customTypesTablePage.createTypeDialog.title).toBeVisible();
-  await customTypesTablePage.createTypeDialog.nameInput.fill(
-    "update",
-  );
+  await customTypesTablePage.createTypeDialog.nameInput.fill("update");
   await expect(
     customTypesTablePage.createTypeDialog.submitButton,
   ).toBeDisabled();
-  await customTypesTablePage.createTypeDialog.nameInput.fill(
-    "insert",
-  );
+  await customTypesTablePage.createTypeDialog.nameInput.fill("insert");
   await expect(
     customTypesTablePage.createTypeDialog.submitButton,
   ).toBeDisabled();

diff --git a/playwright/tests/pageTypes/pageTypesTable.spec.ts b/playwright/tests/pageTypes/pageTypesTable.spec.ts
@@ -96,13 +96,9 @@ test("I cannot create a page type with a name update or insert", async ({
   await pageTypesTablePage.openCreateDialog();
 
   await expect(pageTypesTablePage.createTypeDialog.title).toBeVisible();
-  await pageTypesTablePage.createTypeDialog.nameInput.fill(
-    "update",
-  );
+  await pageTypesTablePage.createTypeDialog.nameInput.fill("update");
   await expect(pageTypesTablePage.createTypeDialog.submitButton).toBeDisabled();
-  await pageTypesTablePage.createTypeDialog.nameInput.fill(
-    "insert",
-  );
+  await pageTypesTablePage.createTypeDialog.nameInput.fill("insert");
   await expect(pageTypesTablePage.createTypeDialog.submitButton).toBeDisabled();
 });
 

diff --git a/playwright/tests/slices/slicesList.spec.ts b/playwright/tests/slices/slicesList.spec.ts
@@ -161,7 +161,6 @@ test("I cannot create a slice with a restricted name ", async ({
   await expect(submitButton).toBeDisabled();
   await nameInput.fill("insert");
   await expect(submitButton).toBeDisabled();
-
 });
 
 test("I cannot create two slices with the same name", async ({