Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create hydranet main #26

Merged
merged 137 commits into from
Jun 12, 2024
Merged

Create hydranet main #26

merged 137 commits into from
Jun 12, 2024

Conversation

Polichinel
Copy link
Collaborator

Created a main.py for purple alien.

But more importantly, this is to be seen as a suggestion to a more general structure. I.e. both how the main is structured, the use of agr parse, and the associated common_utils. But also further the way that the hierarchic of scripts main.pt<-model_run_handlers<-model_run_managers<-(training, testing, forecasting scripts respectively) ids set up.

We should think about how much of this we can abstract out to common_utils. Of course, the deeper we go into these hierarchies the less we should expect the code to be generalizable.

Thanks in advance for any notes and feedback!

Copy link
Collaborator Author

@Polichinel Polichinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments to Sara's comments.

Generally followed advice. changed os the pathlib throughout the script, renamed some script and relocated to central scripts to new dir src/management as they seemed too important to hide in utils, but we still want a clean main.py. LMKWYT.

Add some new functions to set_path script to accommodate ESCW PR, but with a change so the PATH_MODEL has its own function (setup_model_path) and is not part of the setup_data_paths

@Polichinel Polichinel merged commit f600535 into main Jun 12, 2024
@Polichinel Polichinel deleted the create_hydranet_main branch June 12, 2024 09:29
@sarakallis sarakallis added the improvement Refactoring, improving existing codebase label Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Refactoring, improving existing codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants