Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADR 19 - Error logging and alerts for training #162

Merged
merged 5 commits into from
Nov 18, 2024
Merged

ADR 19 - Error logging and alerts for training #162

merged 5 commits into from
Nov 18, 2024

Conversation

xiaolong0728
Copy link
Collaborator

Propose ADR 19 Log Files for Model Training

@xiaolong0728 xiaolong0728 linked an issue Nov 5, 2024 that may be closed by this pull request
Draft ADR 019 - Error Logging and Alerts for Model Training #101
Closed
6 tasks
marinamatic
marinamatic reviewed Nov 7, 2024
View reviewed changes
Copy link
Contributor

@marinamatic marinamatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of small comments that can also be disregarded if they don't seem useful!

documentation/ADRs/019_log_files_for_model_training.md Outdated Show resolved Hide resolved
documentation/ADRs/019_log_files_for_model_training.md Outdated Show resolved Hide resolved
documentation/ADRs/019_log_files_for_model_training.md Outdated Show resolved Hide resolved
documentation/ADRs/019_log_files_for_model_training.md Show resolved Hide resolved
Polichinel
Polichinel approved these changes Nov 18, 2024
View reviewed changes
Copy link
Collaborator

@Polichinel Polichinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super - I added a bit and accepted the ADR

@Polichinel Polichinel merged commit 33c0d8d into development Nov 18, 2024
1 check passed
@Polichinel Polichinel deleted the error_logging_and_alerts branch November 18, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marinamatic marinamatic marinamatic left review comments

@Polichinel Polichinel Polichinel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Draft ADR 019 - Error Logging and Alerts for Model Training
3 participants
@xiaolong0728 @Polichinel @marinamatic