Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all pgm level models #156

Merged
merged 49 commits into from
Nov 13, 2024
Merged

Add all pgm level models #156

merged 49 commits into from
Nov 13, 2024

Conversation

xiaolong0728
Copy link
Collaborator

  1. All pgm level models are added. Newly created ones use darts stepshifter.
  2. One cm level model (brown cheese) finished with Borbala.
  3. Update stepshifter darts to solve the problem that cm data have discrete time series (countries appear and disappear)
  4. Update set_path logging level from INFO to DEBUG, but WARNING is kept.

@xiaolong0728 xiaolong0728 changed the base branch from production to development November 4, 2024 09:22
Copy link
Contributor

@smellycloud smellycloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall everything works but there are missing dirs inside a few models. old_money, midnight_rain and invisible_string. Maybe more?

common_utils/model_path.py Outdated Show resolved Hide resolved
common_utils/set_path.py Outdated Show resolved Hide resolved
models/.DS_Store Outdated Show resolved Hide resolved
common_utils/views_stepshifter_darts/stepshifter.py Outdated Show resolved Hide resolved
models/dark_paradise/main.py Outdated Show resolved Hide resolved
@xiaolong0728 xiaolong0728 linked an issue Nov 5, 2024 that may be closed by this pull request
3 tasks
@smellycloud
Copy link
Contributor

Problem with invisible_string. python main.py --train. I'm guessing something is up with the queryset.

Traceback (most recent call last):
  File "/Users/user/Desktop/views_pipeline/models/invisible_string/main.py", line 35, in <module>
    execute_single_run(args)
  File "/Users/user/Desktop/views_pipeline/models/invisible_string/src/management/execute_model_runs.py", line 39, in execute_single_run
    get_data(args, config["name"], args.drift_self_test)
  File "/Users/user/Desktop/views_pipeline/models/invisible_string/src/dataloaders/get_data.py", line 11, in get_data
    data, alerts = fetch_or_load_views_df(model_name, args.run_type, path_raw, self_test, use_saved=args.saved)
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/user/Desktop/views_pipeline/common_utils/utils_dataloaders.py", line 245, in fetch_or_load_views_df
    df, alerts = get_views_df(model_name, partition, self_test, override_month)  # which is then used here
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/user/Desktop/views_pipeline/common_utils/utils_dataloaders.py", line 202, in get_views_df
    df, alerts = fetch_data_from_viewser(model_name, month_first, month_last, drift_config_dict, self_test)
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/user/Desktop/views_pipeline/common_utils/utils_dataloaders.py", line 41, in fetch_data_from_viewser
    queryset_base = model_path.get_queryset()  # just used here..
                    ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/user/Desktop/views_pipeline/common_utils/model_path.py", line 485, in get_queryset
    return self._queryset.generate() if self._queryset else None
           ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/user/Desktop/views_pipeline/common_querysets/queryset_invisible_string.py", line 55, in generate
    .transform.spatial.sptime_dist(distances,1,1.0,0.0)
                                   ^^^^^^^^^
NameError: name 'distances' is not defined
2024-11-06 11:02:43,314 /Users/user/Desktop/views_pipeline/common_utils/global_cache.py [global_cache.py:212] [10812] [MainThread] - INFO - Cache file: /Users/user/Desktop/views_pipeline/.global_cache.pkl deleted at exit

Copy link
Collaborator

@Polichinel Polichinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@Polichinel Polichinel merged commit 021e50b into development Nov 13, 2024
1 check passed
@Polichinel Polichinel deleted the pgm_models branch November 13, 2024 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Complete Model Scaffolding for Remaining PGM-Level Models
4 participants