Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log datafetch timestamp #115

Merged
merged 6 commits into from
Oct 30, 2024
Merged

Log datafetch timestamp #115

merged 6 commits into from
Oct 30, 2024

Conversation

xiaolong0728
Copy link
Collaborator

  • Log data_fetch_timestamp as a .txt file to data/raw, then the model log in data/generated can read the data_fetch_timestamp from the file.
  • Update validate arguments: if --train is not set, you should only use saved data
  • Remove validate=False (I misunderstood before and correct now)

Polichinel
Polichinel approved these changes Oct 30, 2024
View reviewed changes
Copy link
Collaborator

@Polichinel Polichinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine - didn't fall asleep this time

@Polichinel Polichinel merged commit 8bedc53 into production Oct 30, 2024
1 check passed
@Polichinel Polichinel deleted the log_datafetch_timestamp branch October 30, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Polichinel Polichinel Polichinel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xiaolong0728 @Polichinel