feat: use multiple RPCs for relayer #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mikelle
reviewed
Dec 9, 2024
| @@ -100,7 +100,7 @@ func NewNode(opts *Options) (*Node, error) { | |||
| ctx, cancel := context.WithTimeout(context.Background(), 15*time.Second) | |||
| defer cancel() | |||
|
|
|||
| client, err := ethclient.DialContext(ctx, opts.L1RPCURL) | |||
| client, err := ethclient.DialContext(ctx, opts.L1RPCURLs[0]) | |||
There was a problem hiding this comment.
What is the point to submit an array, if we just take the first value?
There was a problem hiding this comment.
Oh, we assume, that first one will work and in wrapped client use the array
There was a problem hiding this comment.
Yes, technically all work. If the first one doesnt work, we will fail in the initialization itself. This is mostly needed if we get rate-limited or if the RPC is down at some later point.
For the initial call we only do it to get the chain-id. We dont configure it in the CLI.
Mikelle
approved these changes
Dec 9, 2024
shaspitz
approved these changes
Dec 9, 2024
mrekucci
approved these changes
Dec 9, 2024
aloknerurkar
force-pushed
the
relayer-multiple-rpcs
branch
from
2771836 to
3297f29
Compare
aloknerurkar
force-pushed
the
relayer-multiple-rpcs
branch
from
3297f29 to
f709ad4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Use multiple RPC URLs for bridge for failover incase one of them is down.
Issue ticket number and link
Fixes # (issue)
Checklist before requesting a review