fix: use single on-chain bridge fee #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaspitz
force-pushed
the
single-finalization-fee
branch
2 times, most recently
from
cbc584a to
f09a651
Compare
Mikelle
approved these changes
Dec 9, 2024
mrekucci
approved these changes
Dec 9, 2024
shaspitz
force-pushed
the
single-finalization-fee
branch
from
de9a531 to
a9fdf7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Fixes https://cantina.xyz/code/d35ebc75-9107-4e58-a923-f81725912138/findings/10
GatewayStorage.finalizationFeefrom the storage of the gateway contracts. Each gateway still stores what's currently defined asGatewayStorage.counterpartyFee(now renamed tocounterpartyFinalizationFee).TransferInitiatedevent is augmented to emit thiscounterpartyFinalizationFee.finalizeTransferis augmented to accept a finalization fee as a part of the transfer being finalized. The relayer would be responsible for ensuring that the_finalizationFeevalue infinalizeTransferis the same as what was specified ascounterpartyFinalizationFeein the correspondingTransferInitiatedevent.By making these changes, we remove the need for one gateway's counterpartyFee to match the other gateway's finalizationFee. The finalization fee is now (only) be set and stored on the origin chain as
counterpartyFinalizationFee, while still being mutable.Checklist before requesting a review