fix: precision issue #493
Merged
fix: precision issue #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckartik
reviewed
Nov 21, 2024
mrekucci
reviewed
Nov 21, 2024
| @@ -29,8 +29,8 @@ contract DeployTestnet is Script { | |||
| address protocolFeeRecipient = address( | |||
| 0xfA0B0f5d298d28EFE4d35641724141ef19C05684 // Placeholder for now, L1 preconf.eth address | |||
| ); | |||
| uint16 feePercent = 2; | |||
| uint16 providerPenaltyPercent = 5; | |||
| uint256 feePercent = 2 * 1e16; // 2% | |||
There was a problem hiding this comment.
The number 1e16 repeats, consider creating a constant.
| @@ -194,7 +194,7 @@ contract BidderRegistryTest is Test { | |||
|
|
|||
| bidderRegistry.openBid(commitmentDigest, 1 ether, bidder, blockNumber); | |||
|
|
|||
| bidderRegistry.retrieveFunds(nextWindow, commitmentDigest, payable(provider), 100); | |||
| bidderRegistry.retrieveFunds(nextWindow, commitmentDigest, payable(provider), 1e18); | |||
There was a problem hiding this comment.
Shouldn't be the 1e18 replaced with PERCENT constant?
| @@ -269,7 +269,7 @@ contract BidderRegistryTest is Test { | |||
| vm.expectRevert(bytes("")); | |||
| bytes32 commitmentDigest = keccak256("1234"); | |||
| bidderRegistry.openBid(commitmentDigest, 1 ether, bidder, blockNumber); | |||
| bidderRegistry.retrieveFunds(nextWindow, commitmentDigest, payable(provider),100); | |||
| bidderRegistry.retrieveFunds(nextWindow, commitmentDigest, payable(provider),1e18); | |||
| @@ -287,7 +287,7 @@ contract BidderRegistryTest is Test { | |||
| vm.prank(address(this)); | |||
| bytes32 commitmentDigest = keccak256("1234"); | |||
| bidderRegistry.openBid(commitmentDigest, 3 ether, bidder, blockNumber); | |||
| bidderRegistry.retrieveFunds(nextWindow, commitmentDigest, payable(provider),100); | |||
| bidderRegistry.retrieveFunds(nextWindow, commitmentDigest, payable(provider),1e18); | |||
There was a problem hiding this comment.
The same is here and also in several other places below.
Mikelle
force-pushed
the
fix/492/precision-issue
branch
from
7bc1f95 to
1dc0fed
Compare
Mikelle
force-pushed
the
fix/492/precision-issue
branch
from
1dc0fed to
e7e2440
Compare
ckartik
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Fixing precision issue
Issue ticket number and link
Fixes #492
Checklist before requesting a review