feat: integrate L1 mock with services #438
Conversation
mrekucci
force-pushed
the
l1-mock-integration
branch
7 times, most recently
from
ce9a891 to
58b4a6c
Compare
| r.metrics.failedFinalizations.WithLabelValues("settlement").Inc() | ||
| continue | ||
| } | ||
| r.metrics.finalizedTransfers.WithLabelValues("settlement").Inc() |
There was a problem hiding this comment.
Am I interpreting this behavior correctly - if the finalizeTransfer transaction is not included in a block (or is reorged out), the relayer will simply skip that transfer and not retry?
Note transfers are enforced to be delivered FIFO in the bridge contracts. This means in the edge case of a tx not getting included in a block, the relayer needs to retry the relevant finalizeTransfer tx until that tx is included.
Further, the relayer needs to eventually confirm each finalizeTransfer tx is included in the finalized destination chain. In case of reorg this requires retries
| return nil | ||
| } | ||
|
|
||
| func (s *Store) IsSettled( |
There was a problem hiding this comment.
Related to above comment, seems "settled" here corresponds to the finalizeTransfer tx being included in the latest block of the destination chain?
We may need to add another state to confirm each transfer is eventually "finalized", ie. the finalizeTransfer tx is in the finalized destination block
| *l1gateway.L1gatewayFilterer | ||
| } | ||
|
|
||
| func (f *L1Filterer) WaitForTransferFinalized(ctx context.Context, startBlock uint64, index *big.Int) error { |
There was a problem hiding this comment.
I believe this function is not reorg resistant, since the event query by default uses "latest" block and not "finalized"
infrastructure/nomad/playbooks/templates/jobs/contracts-deployer.nomad.j2
Show resolved
Hide resolved
mrekucci
force-pushed
the
l1-mock-integration
branch
from
138a57f to
31d4855
Compare
mrekucci
force-pushed
the
l1-mock-integration
branch
from
479482a to
1254ebe
Compare
Describe your changes
L1 mock integration with all services within the cluster
Fixes # (issue)
Checklist before requesting a review