feat: stronger builder attribution #432
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckartik
force-pushed
the
ckartik/add-relay-attribution-support
branch
from
c41b3f8 to
7950e6e
Compare
ckartik
commented
Oct 23, 2024
| ) external onlyOracle whenNotPaused { | ||
| address _winner = blockBuilderNameToAddress[_winnerGraffiti]; | ||
| address _winner = _providerRegistry.getEoaFromBLSKey(_winnerBLSKey); |
There was a problem hiding this comment.
I plan to remove the concept of a builder in the blocktracker, retaining only the BLS key responsible for building the block number. However, due to an ongoing audit, I will maintain the current approach to minimize changes to the contract architecture.
ckartik
commented
Oct 28, 2024
oracle/cmd/main.go
Outdated
| EnvVars: []string{"MEV_ORACLE_RELAY_URLS"}, | ||
| Value: cli.NewStringSlice( | ||
| "https://boost-relay.flashbots.net/relay/v1/data/bidtraces/proposer_payload_delivered", | ||
| "https://bloxroute.max-profit.blxrbdn.com/relay/v1/data/bidtraces/proposer_payload_delivered", |
There was a problem hiding this comment.
Need to have a clean way to decision if these should be holesky v.s mainnet values.
|
Duplicated by #468 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR introduces a new feature to fetch and utilize relay data in the MEV oracle. Key changes include:
relay-urlsto specify URLs for relays.watchRelaysfunction in theL1Listenerto periodically fetch data from specified relays.RelayDatastruct to store and manage relay information.watchL1Blockfunction to use the fetched builder public key.NewL1Listenerfunction to accept relay URLs as a parameter.node.gofile to accommodate the new relay functionality.These changes allow the oracle to fetch and utilize real-time data from multiple relays, enhancing its ability to track and verify block proposers beyond the simple grafiti approach.
This PR will go along with contract changes that both utilize the BLS key in builder attribution, and easy retrieval of provider address form BLS key.
Issue ticket number and link
Fixes # (issue)
Checklist before requesting a review