feat(transactor, txmonitor): add tx management #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mikelle
reviewed
Apr 25, 2024
aloknerurkar
force-pushed
the
contractevents
branch
from
021000a to
01135d6
Compare
aloknerurkar
force-pushed
the
transactor
branch
from
fc183d2 to
f799a76
Compare
Mikelle
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in oracle we use the abi-gen code to issue transactions to our contracts. The transactor pkg provides
bind.ContractTransactorimplementation which can be used across multiple abi-gen "TransactorSessions" to synchronize nonce management and ordering the txns to geth backend correctly.With this transactor, we should be able to use the abi-gen code in mev-commit p2p as well. This will reduce a lot of code across the p2p module.
Along with sending transactions, the monitoring of sent transactions is essential. This is existing functionality in mev-commit p2p, but can be used in oracle as well to better monitor the transaction statuses and handle failures/cancellations etc.
The monitor along with the transactor should provide enough functionality required by both oracle and p2p and hence it is better to be placed in the
xmodule.