Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds logging for preconfirmations #314

Merged
merged 5 commits into from
Aug 7, 2024
Merged

Adds logging for preconfirmations #314

merged 5 commits into from
Aug 7, 2024

Conversation

ckartik
Copy link
Contributor

@ckartik ckartik commented Aug 5, 2024

Describe your changes

Adds the following log to the p2p node:
Screenshot 2024-08-05 at 11 22 30 AM

Fixes #303

Checklist before requesting a review

  • I have added tests that prove my fix is effective or that my feature works
  • I have made corresponding changes to the documentation
  • I have tested this code by deploying the infrastructure and ensuring that commitments are being settled

@ckartik ckartik requested a review from aloknerurkar August 6, 2024 19:52
@ckartik ckartik merged commit 5e58cd5 into main Aug 7, 2024
6 checks passed
@ckartik ckartik deleted the ckartik/bid-reject-ux branch August 7, 2024 02:14
mrekucci pushed a commit that referenced this pull request Aug 7, 2024
* feat: logs details of preconf in logs

* feat: stops sending bid rejection over node

* chore: leave bid reject for now
ckartik added a commit that referenced this pull request Aug 7, 2024
* feat: updates fee mechanism for slashing to additive penalty

* feat: updates penalty to be 5% for slashing

* chore: renames for more descriptive explaination

* feat: adds fixes to tests

* chore: fix fee is 10 in tests

* feat: updates naming of variable

* chore: revert geth

* chore: fix naming in tests

* feat: update naming more and bump abi

* chore: update naming in comments

* Adds logging for preconfirmations (#314)

* feat: logs details of preconf in logs

* feat: stops sending bid rejection over node

* chore: leave bid reject for now
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bid Acceptance Log doesn't show up no bidder node
2 participants