chore: fully enable solhint linter #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaspitz
commented
Jul 20, 2024
| "imports-on-top": "error", | ||
| "visibility-modifier-order": "error", | ||
| "reason-string": "error", | ||
| "gas-custom-errors": "off" |
There was a problem hiding this comment.
@Mikelle I turned this one off due to ethereum/go-ethereum#26823
commit 946c209 Author: Shawn <[email protected]> Date: Fri Jul 19 18:47:56 2024 -0700 chore: update abis + bindings commit 6e74e2b Author: Shawn <[email protected]> Date: Fri Jul 19 18:43:35 2024 -0700 fix: smaller require msges commit 5f206ec Author: Shawn <[email protected]> Date: Fri Jul 19 18:16:26 2024 -0700 chore: go back to require statements due to ethereum/go-ethereum#26823 commit a6a076e Author: Mikhail Wall <[email protected]> Date: Sat Jul 20 00:57:26 2024 +0200 feat: Fully enable solhint merge (#258) * fix: fixed bidder registry linter * fix: fixed blockTracker * fix: fixing oracle and fixed interfaces * fix: merged with Shawn branch * fix: added more custom errors commit 0bc368c Author: Shawn <[email protected]> Date: Fri Jul 19 14:56:58 2024 -0700 fix: missed a disable line commit 0b1f929 Author: Shawn <[email protected]> Date: Fri Jul 19 14:55:29 2024 -0700 refactor: address unused imports point commit 3327469 Author: Shawn <[email protected]> Date: Fri Jul 19 14:54:36 2024 -0700 refactor: correct style related points commit ce642d8 Author: Shawn <[email protected]> Date: Fri Jul 19 14:25:35 2024 -0700 fix: proper use of solhint disable for empty blocks check commit 9971497 Author: Shawn <[email protected]> Date: Fri Jul 19 14:12:04 2024 -0700 refactor: correct all instances of gas-length-in-loops infractions commit 33f603d Author: Shawn <[email protected]> Date: Fri Jul 19 14:02:14 2024 -0700 refactor: correct all instances of private-vars-leading-underscore infractions commit ba33b03 Author: Shawn <[email protected]> Date: Fri Jul 19 13:28:24 2024 -0700 refactor: refactor contracts for all instances of ordering infractions Co-Authored-By: Mikhail Wall <[email protected]>
Mikelle
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #246
Enables all solhint rules that were deemed useful for us from https://protofire.github.io/solhint/docs/rules.html, and refactors contracts as needed to abide by new error rules.
This PR should effectively be a refactor, but small differences in behavior exist like shorter error messages.
Devnet tested in https://github.com/primev/mev-commit/actions/runs/10016705210
Note https://github.com/primev/mev-commit/tree/fully-enable-solhint has individual commits of this PR but I had to squash merge due to commit linting ci..