Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove special characters from passphrase generation #199

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

mrekucci
Copy link
Collaborator

@mrekucci mrekucci commented Jul 5, 2024

Removing special characters from the passphrase character set eliminates problems similar to the following:

TASK [Push Generated Secrets to Vault] *****************************************
Friday 05 July 2024  00:02:38 +0000 (0:00:13.870)       0:00:39.462 *********** 
fatal: [69.67.150.157 -> localhost]: FAILED! => 
  msg: |-
    the field 'args' has an invalid value ({'url': '{{ vault_address }}/v1/{{ vault_kv_engine_path }}/data/{{ vault_secret_path }}', 'method': 'POST', 'body_format': 'json', 'headers': {'X-Vault-Token': '{{ vault_init.json.root_token }}', 'Content-Type': 'application/json'}, 'body': "{{ {'data': (lookup('file', dist_dir + '/secrets.json') | from_json)} | to_json }}", 'status_code': [200, 204], 'validate_certs': False}), and could not be converted to dict. The error was: Expecting value: line 1 column 1 (char 0)
  
    The error appears to be in '/home/runner/work/mev-commit/mev-commit/infrastructure/nomad/playbooks/deploy.yml': line 520, column 7, but may
    be elsewhere in the file depending on the exact syntax problem.
  
    The offending line appears to be:

@mrekucci mrekucci requested a review from ayshvm July 5, 2024 07:51
@mrekucci mrekucci merged commit 9099c9c into main Jul 5, 2024
6 checks passed
@mrekucci mrekucci deleted the fix-passphrase-gen branch July 5, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant