fix: forge build now specifies correct script directory #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaspitz
commented
Jun 26, 2024
| @@ -6,7 +6,6 @@ import "../contracts/ProviderRegistry.sol"; | |||
| import "../contracts/PreConfCommitmentStore.sol"; | |||
| import "../contracts/Oracle.sol"; | |||
| import "../contracts/Whitelist.sol"; | |||
| import "../contracts/validator-registry/ValidatorRegistryV1.sol"; | |||
There was a problem hiding this comment.
this dep is unneeded for core deployment
shaspitz
commented
Jun 26, 2024
| @@ -1,35 +1,38 @@ | |||
| // SPDX-License-Identifier: BSL 1.1 | |||
There was a problem hiding this comment.
Changes necessary to make this script build and pass ci
mrekucci
approved these changes
Jun 26, 2024
kant777
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously bugs like #173 would not be caught by ci, because forge thinks scripts reside in the
scriptdirectory by default. Our script directory is actuallyscriptsas addressed in this PR. Nowforge test,forge buildetc. will fail as expected when one of the solidity scripts doesn't build.