feat: keystore optimization #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrekucci
reviewed
Jun 6, 2024
| "Invalid dispatch timestamp, block.timestamp - dispatchTimestamp < commitmentDispatchWindow" | ||
| ); | ||
|
|
||
| uint256 minTime = block.timestamp - commitmentDispatchWindow; |
There was a problem hiding this comment.
It would be good to leave some commentary on why it was changed this way to avoid unwanted changes that would reintroduce the problem.
There was a problem hiding this comment.
Should I describe previous way in the comments then?
aloknerurkar
reviewed
Jun 6, 2024
added 2 commits
June 6, 2024 17:46
Mikelle
force-pushed
the
keystore-optimization
branch
from
f19a706 to
0a84caf
Compare
Mikelle
force-pushed
the
keystore-optimization
branch
from
e931e7e to
08a135d
Compare
aloknerurkar
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.